Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query patterns #273

Merged
merged 36 commits into from
Sep 13, 2024
Merged

Add query patterns #273

merged 36 commits into from
Sep 13, 2024

Conversation

nck-mlcnv
Copy link
Contributor

No description provided.

@nck-mlcnv nck-mlcnv self-assigned this Sep 5, 2024
@nck-mlcnv nck-mlcnv linked an issue Sep 5, 2024 that may be closed by this pull request
Add Patternized Queries back #272
Closed
@nck-mlcnv
Update documentation
31676aa
@nck-mlcnv
Fix default value of config
bbc7a20
@nck-mlcnv
Remove exception
f9ce17a
@nck-mlcnv
Fix hashcode
8e2a09c
@nck-mlcnv
Revert "Fix hashcode"
7d6ec5c 
This reverts commit 8e2a09c.
@nck-mlcnv
Revert "Remove exception"
e11de85 
This reverts commit f9ce17a.
@nck-mlcnv
Refactoring of QueryList
6735344 
* QueryList is now an interface
* added new abstract class FileBasedQueryList
* old FileBasedQueryList is now FileReadingQueryList
* InMemQueryList.java is no FileCachingQueryList
* add StringListQueryList
* remove StringListQuerySource.java
@nck-mlcnv
Remove logging statement
c311579
@nck-mlcnv
Update doc
d2d6b96
@nck-mlcnv
Update graalvm suite
7ff23b5
@nck-mlcnv
Fix native compilation
ed5e74d
@nck-mlcnv
Update logging statement
9545444
@nck-mlcnv nck-mlcnv marked this pull request as ready for review September 5, 2024 12:36
bigerl
bigerl requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. General design seems good. I am also happy to see that apperently only very few/small changes to other parts were necessary to integrate this. So, nice work with the original v4 release. 👍 Please find my suggestions for imporvements below.

schema/iguana-schema.json Show resolved Hide resolved
docs/configuration/queries.md Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/test/java/org/aksw/iguana/cc/query/handler/PatternQueriesTest.java Outdated Show resolved Hide resolved
bigerl
bigerl requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the update. Almost there. This change request should be the last.

docs/configuration/queries.md Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java Outdated Show resolved Hide resolved
@nck-mlcnv nck-mlcnv merged commit 956a59d into develop Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalexandrasilva aalexandrasilva aalexandrasilva left review comments

@bigerl bigerl bigerl approved these changes

Assignees

@nck-mlcnv nck-mlcnv

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Patternized Queries back
3 participants
@nck-mlcnv @bigerl @aalexandrasilva